Create UserService

app/Http/Controllers/UserController.php

@@ -8,6 +8,7 @@ use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Hash;
 use Illuminate\Support\Facades\Log;
 use App\Services\GetRole;
+use App\Services\UserService;
 
 class UserController extends Controller
 {
@@ -18,19 +19,7 @@ class UserController extends Controller
 
     public function me(Request $request): JsonResponse {
         try {
-            return response()->json([
+            return response()->json(UserService::getData($request->user()->id));
-                "id" => $request->user()->id,
-                "name" => $request->user()->name,
-                "lastname" => $request->user()->lastname,
-                "email" => $request->user()->email,
-                "role" => GetRole::getRole($request->user()->role),
-                "phone" => $request->user()->phone,
-                "created_at" => $request->user()->created_at,
-                "updated_at" => $request->user()->updated_at,
-                "verfied_at" => $request->user()->verfied_at,
-                "validate" => $request->user()->validate,
-                "tasks" => $request->user()->tasks
-            ]);
         } catch(\Exception $e) {
             Log::info($e->getMessage());
             return response()->json(['message' => "Server error"], 500);
@@ -83,16 +72,7 @@ class UserController extends Controller
     public function getUser(Request $request, int $id): JsonResponse {
 
         try {
-            $user = User::find($id);
+            return response()->json(UserService::getData($id));
-            return response()->json([
-                'id' => $user->id,
-                'name' => $user->name,
-                'lastname' => $user->lastname,
-                'email' => $user->email,
-                'phone' => $user->phone ? $user->phone : "null",
-                'validate' => $user->validate,
-                'role' => $user->role,
-            ]);
         } catch(\Exception $e) {
             Log::info($e->getMessage());
             return response()->json(['message' => "Server error"], 500);

app/Services/UserService.php

@@ -0,0 +1,25 @@
+<?php
+
+namespace App\Services;
+use App\Models\User;
+
+class UserService
+{
+    public static function getData(int $id) : array {
+
+        $user = User::find($id);
+        return [
+            "id" => $user->id,
+            "name" => $user->name,
+            "lastname" => $user->lastname,
+            "email" => $user->email,
+            "role" => GetRole::getRole($user->role),
+            "phone" => $user->phone,
+            "created_at" => $user->created_at,
+            "updated_at" => $user->updated_at,
+            "verfied_at" => $user->verfied_at,
+            "validate" => $user->validate,
+            "tasks" => $user->tasks
+        ];
+    }
+}